-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing WINVER check to prsht.h #717
base: master
Are you sure you want to change the base?
Conversation
I can not find such information anywhere. |
I don't have any sources, however it requires the |
I think you use Windows headers incorrectly. |
The problem is that |
It looks like Win32s doesn't include or reference prsht.h any way. |
NT3.1 SDK also doesn't contain prsht.h header file. |
The error for Win32s with WINVER=0x030A is:
winuser.h in the NT headers does not define NMHDR unless WINVER >= 0x400. So if NMHDR is not valid for Windows 3.1, and the property sheet stuff didn't exist in Windows 3.1, why should prsht.h declare anything at all? Or better yet, why is it included anyway? |
My comment note that it is not simple problem as it looks like. This PR (partial change) only mask a problem because existing OW WIN32 header files are supporting Windows NT 4.0 and above. To really solve this issue need to review header files (add appropriate guards for lower versions) to be compatible with Win32s, Windows NT 3.1 and Windows NT 3.5 that it is much more work. Now it is failing that user understand that some problem exists otherwise user will require full support for Win32s, Windows NT 3.1 and 3.5 etc. If anybody do such review I will accept it but this change is unwanted because mask problem only. It will require add new linker target too. |
No description provided.